add searchProviders parameter to searchDiscover method #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix |
3 tasks
JonnyWong16
reviewed
Jul 2, 2024
plexapi/myplex.py
Outdated
| """ Search for movies and TV shows in Discover. | ||
| Returns a list of :class:`~plexapi.video.Movie` and :class:`~plexapi.video.Show` objects. | ||
|
|
||
| Parameters: | ||
| query (str): Search query. | ||
| limit (int, optional): Limit to the specified number of results. Default 30. | ||
| libtype (str, optional): 'movie' or 'show' to only return movies or shows, otherwise return all items. | ||
| searchprovider (str, optional): 'discover' for default behavior |
There was a problem hiding this comment.
Suggested change
| searchprovider (str, optional): 'discover' for default behavior | |
| searchProviders (str, optional): 'discover' for default behavior |
There was a problem hiding this comment.
Maybe even just name the argument providers.
JonnyWong16
approved these changes
Jul 3, 2024
glensc
approved these changes
Jul 5, 2024
|
Blocks Taxel/PlexTraktSync#2002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the searchDiscover method is broken. Plex now requires a new parameter called searchProviders to be provided in the query. This parameter is a comma separated string with the following values:
I've updated the searchDiscover method to default to just "discovery", with the option for users to include the other providers if they wish.