-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaContainer
class is now a list
#1373
Conversation
MediaContainer
class is now a list
3508a3e
to
f3ef67b
Compare
- can now support totalSize as returned from server
f3ef67b
to
f2ea869
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This looks greats. It seems to be mostly working, but is it possible to load the other >> results = plex.library.section("Movies (Test)").all() # results is now a MediaContainer
>> results.librarySectionID # this is None <MediaContainer size="17" allowSync="1" art="/:/resources/movie-fanart.jpg" identifier="com.plexapp.plugins.library" librarySectionID="41" librarySectionTitle="Movies (Test)" librarySectionUUID="e9535986-3fd3-4f88-9793-77a50b04dd01" mediaTagPrefix="/system/bundle/media/flags/" mediaTagVersion="1708667686" thumb="/:/resources/movie.png" title1="Movies (Test)" title2="All Movies (Test)" viewGroup="movie" viewMode="65592">
|
d75ab57
to
af113ae
Compare
af113ae
to
06819fa
Compare
06819fa solves this test fails seems unrelated |
* regression test for Taxel/PlexTraktSync#1901 * bugfix Taxel/PlexTraktSync#1901
Description
fetchItems
returns a MediaContainer, exactly how server does and is also a python list! Hence it would not break any current api.additionally, it now supports totalSize attr
The only breaking change is that MediaContainer can now only accept
initpath
andparent
as keword-only arguments in its initialisation, which I don't think anyone would be using.Fixes #1372
Type of change
Please delete options that are not relevant.
Checklist: