Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev off when environment is not active #979

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Feb 22, 2024

Which was previously throwing _pkgx_dev_off not found.

And also make sure to pass rm -f as some people alias rm to rm -i, which can come from the popular OMZ common-aliases: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/common-aliases#file-handling

And also make sure to pass rm -f as some people alias rm to rm -i.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 22, 2024
@jhheider
Copy link
Contributor

And also make sure to pass rm -f as some people alias rm to rm -i, which can come from the popular OMZ common-aliases: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/common-aliases#file-handling

could also just be explicit about /bin/rm to avoid dealing with aliases.

@felipecrs
Copy link
Contributor Author

could also just be explicit about /bin/rm to avoid dealing with aliases.

Right, or better yet command rm. But I find rm -f nicer.

Of course, let me know if you want me to change it.

@mxcl mxcl force-pushed the main branch 2 times, most recently from 9038067 to 342373c Compare April 23, 2024 21:22
@felipecrs felipecrs mentioned this pull request Sep 6, 2024
@mxcl
Copy link
Member

mxcl commented Sep 6, 2024

We should be explicit with /bin/rm will patch that in after.

@mxcl mxcl merged commit 6806170 into pkgxdev:main Sep 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants