Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Include PYPI_PN opportunities in PythonInlinePyPIURI #569

Closed
wants to merge 2 commits into from

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 21, 2023

No description provided.

Technically this is less optimal than the original code but it opens up
the possibility of enabling PYPI_PN support next.

Signed-off-by: Michał Górny <[email protected]>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: +0.01 🎉

Comparison is base (6bb4201) 80.20% compared to head (963eeb2) 80.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   80.20%   80.21%   +0.01%     
==========================================
  Files          56       56              
  Lines        8436     8437       +1     
  Branches     1910     1911       +1     
==========================================
+ Hits         6766     6768       +2     
+ Misses       1570     1569       -1     
  Partials      100      100              
Impacted Files Coverage Δ
src/pkgcheck/checks/python.py 56.11% <16.66%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like it.

Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge it soon I hope (net issues should be fixed today).

@mgorny
Copy link
Contributor Author

mgorny commented Mar 24, 2023

Fixed formatting. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants