Add File.ReadFrom test on a SectionReader #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
reviewed
Dec 19, 2021
|
Looks like quite excellent work! |
greatroar
force-pushed
the
readfrom-test
branch
2 times, most recently
from
31306ef
to
2f401a4
Compare
puellanivis
reviewed
Dec 23, 2021
This tests ReadFrom's determining concurrency from the estimated input size. go test -cover -integration, before: coverage: 77.3% of statements After: coverage: 79.2% of statements
greatroar
force-pushed
the
readfrom-test
branch
from
2f401a4
to
1fffa62
Compare
puellanivis
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests ReadFrom's determining concurrency from the estimated input
size. go test -cover -integration, before:
After: