Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article huggingface #61

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Article huggingface #61

merged 9 commits into from
Jan 15, 2024

Conversation

Involute1
Copy link
Contributor

No description provided.

@Involute1 Involute1 added the presentations Anything about the presentations label Dec 29, 2023
@Involute1 Involute1 self-assigned this Dec 29, 2023
@Involute1 Involute1 changed the title Presentation huggingface Article huggingface Dec 29, 2023
Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Involute1!

Please check out my comments.

Furthermore, it would be great if you could also include the following topics from the Hugging Face docs:

@pkeilbach pkeilbach linked an issue Jan 9, 2024 that may be closed by this pull request
mkdocs.yml Outdated Show resolved Hide resolved
Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further comments, @Involute1. Please re-request a review when you're done ✌🏼

Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment and I think we are good to go 😉

Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Congrats on the first student contribution to this repo @Involute1 🥳

@pkeilbach pkeilbach self-requested a review January 12, 2024 18:26
Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test - sorry, needed to test a branch protection setting.

Copy link
Owner

@pkeilbach pkeilbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkeilbach pkeilbach merged commit 6bd61b9 into main Jan 15, 2024
@pkeilbach pkeilbach deleted the presentation-huggingface branch January 15, 2024 18:36
ka161heg pushed a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presentations Anything about the presentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presentation on Hugging Face
2 participants