Skip to content

Commit

Permalink
Merge pull request tektoncd#386 from chmouel/openshift-disable-testta…
Browse files Browse the repository at this point in the history
…skrun-retry

Remove TestTaskRunRetry, too much flakyness
  • Loading branch information
openshift-merge-robot authored Apr 24, 2020
2 parents 119e1c5 + d866a8b commit 29bebe2
Showing 1 changed file with 38 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
From cd0c10a3a1eaae979121959146b439c9aa373e62 Mon Sep 17 00:00:00 2001
From: Chmouel Boudjnah <[email protected]>
Date: Fri, 17 Apr 2020 08:48:19 +0200
Subject: [PATCH] Remove TestTaskRunRetry, too much flakyness

Signed-off-by: Chmouel Boudjnah <[email protected]>
---
test/retry_test.go | 1 +
test/v1alpha1/retry_test.go | 1 +
2 files changed, 2 insertions(+)

diff --git a/test/retry_test.go b/test/retry_test.go
index cce0874b8..3169c2016 100644
--- a/test/retry_test.go
+++ b/test/retry_test.go
@@ -33,6 +33,7 @@ import (
// TestTaskRunRetry tests that retries behave as expected, by creating multiple
// Pods for the same TaskRun each time it fails, up to the configured max.
func TestTaskRunRetry(t *testing.T) {
+ t.Skip("Flaky")
c, namespace := setup(t)
knativetest.CleanupOnInterrupt(func() { tearDown(t, c, namespace) }, t.Logf)
defer tearDown(t, c, namespace)
diff --git a/test/v1alpha1/retry_test.go b/test/v1alpha1/retry_test.go
index ab7add104..a6116c6aa 100644
--- a/test/v1alpha1/retry_test.go
+++ b/test/v1alpha1/retry_test.go
@@ -34,6 +34,7 @@ import (
// TestTaskRunRetry tests that retries behave as expected, by creating multiple
// Pods for the same TaskRun each time it fails, up to the configured max.
func TestTaskRunRetry(t *testing.T) {
+ t.Skip("Flaky")
c, namespace := setup(t)
knativetest.CleanupOnInterrupt(func() { tearDown(t, c, namespace) }, t.Logf)
defer tearDown(t, c, namespace)
--
2.25.0

0 comments on commit 29bebe2

Please sign in to comment.