fix: fix removeUnnecessaryJoints and combineSkeletons #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it processes a same bone index attribute twice or more, which collapses the mesh We are going to fix combineSkeletons in the next commit
0b5vr
commented
Dec 13, 2024
Comment on lines
+113
to
+114
| bones.push(mesh.skeleton.bones[oldIndex]); | ||
| boneInverses.push(mesh.skeleton.boneInverses[oldIndex]); |
There was a problem hiding this comment.
Considering cases multiple meshes share the same skin index attribute but not the same bones (which is unlikely) or boneInverses (which is more likely), we moved these lines here
It sometimes modified a skin index attribute twice or more, which collapses the skinned mesh rendering I'm sorry that it became a huge refactor ._.
ke456-png
reviewed
Dec 16, 2024
fix doc comment of listUsedIndices See: #1557 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
removeUnnecessaryJointsandcombineSkeletons.It processes the same bone index attribute twice or more, which collapses the mesh.
TODOs
Points need review