VRMUtils.combineMorphs #1546
Open
VRMUtils.combineMorphs #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will prevent shader errors caused by the limitation of the number of morph targets, especially on mobile devices I'm yet to do the sufficient behavior verification expose `VRMExpression.binds`, add `VRMExpression.deleteBind()`
Was not working on some VRoid models; it attempted to access `morphAttributes.position` where it doesn't exist
0b5vr
added
bug
|
Since morph targets will be written into a data texture array, it don't have to be an interleaved buffer. https://github.com/mrdoob/three.js/blob/dev/src/renderers/webgl/WebGLMorphtargets.js#L62 |
morphTargetsRelative should be always false when we're loading glTF models but just in case
also added a doc comment to `VRMExpression.addBind`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #1369
This PR will add
VRMUtils.combineMorphs.This function will prevent shader errors caused by the limitation of the number of morph targets, especially on mobile devices.
This might potentially improve the performance when using models with a lot of unnecessary morphs.
This PR also exposes
VRMExpression.bindsand addsVRMExpression.deleteBind().These were required to implement
VRMUtils.combineMorphs.