Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to 'auto' instead of 'both' for MeshAnnotation #1515

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mrxz
Copy link

@mrxz mrxz commented Oct 28, 2024

The specification states that the fallback value for mesh annotations should be auto. In case there is no firstPerson property, it should still be treated as auto. I noticed three-vrm instead used both as fallback. This PR changes the fallback value from both to auto and ensures this is done whether or not there is a firstPerson property.

I could not find out if this applies to VRM0 as well, so I've left _v0Import unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant