Bump Three.js to r168 #1465
Merged
Bump Three.js to r168 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from r168, `setupNormal` returns the normal node instead of assigning inside the `NodeMaterial.setupNormal` See: mrdoob/three.js#29137
In r168, `tslFn` has been renamed to `Fn` See: mrdoob/three.js#29064
@types/three is not released yet
`normalMap` is no longer a node element, we use this as an individual node instead This should work also in r167 See: mrdoob/three.js#29187
|
We are going to wait |
Update type definition of `FnCompat` according the latest `@types/three`
`XRWebGLDepthInformation` doesn't exist in the existing v0.5.16 and that had been causing build errors
The return type should be matched to the super class (NodeMaterial)
|
Ready to merge, Working fine in (r167, r168) x (WebGL, WebGPU) matrix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setupNormaltslFncallingnormalMapis no longer a node element, we use this as an individual node insteadSee each commits for details.
Points need review