Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: chore: remove downlevel-dts #1302

Merged
merged 3 commits into from
Jun 10, 2024
Merged

BREAKING: chore: remove downlevel-dts #1302

merged 3 commits into from
Jun 10, 2024

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Sep 29, 2023 •
edited
Loading

BREAKING: TypeScript 3.9 is released in May 2020. It does not make sense to support version before that.

  1. Renamed all .ts -> .d.ts inside types-* packages
  2. moved src -> types
  3. remove building downlevel-dts but keeps files, ignores, etc

Work towards #1293. This should also bring down build time a lot.

@yue4u yue4u changed the title chore: remove downlevel-dts BREAKING: chore: remove downlevel-dts Sep 29, 2023
@yue4u yue4u force-pushed the chore/remove-downlevel-dts branch 3 times, most recently from 19b665f to 2b34689 Compare September 29, 2023 03:12
@yue4u yue4u requested a review from 0b5vr September 29, 2023 03:18
@0b5vr 0b5vr mentioned this pull request Nov 22, 2023
Closed
@0b5vr 0b5vr added the Breaking Change Choose wisely label Nov 22, 2023
@yue4u yue4u mentioned this pull request May 17, 2024
Merged
@0b5vr 0b5vr added this to the v3 milestone May 20, 2024
@0b5vr 0b5vr changed the base branch from dev to dev-v3 May 20, 2024 02:49
@yue4u yue4u force-pushed the chore/remove-downlevel-dts branch 9 times, most recently from abe7da1 to 136ce08 Compare June 6, 2024 06:54
@yue4u yue4u force-pushed the chore/remove-downlevel-dts branch from 136ce08 to f0c66b6 Compare June 6, 2024 07:07
@0b5vr
Copy link
Contributor

0b5vr commented Jun 10, 2024

@yue4u would you check .eslintignore and .gitignore ?
I searched the entire repo for ts* and there are these leftovers.

@yue4u
Copy link
Contributor Author

yue4u commented Jun 10, 2024

@yue4u would you check .eslintignore and .gitignore ? I searched the entire repo for ts* and there are these leftovers.

a1167dd

@0b5vr
Copy link
Contributor

0b5vr commented Jun 10, 2024

LGTM! thank you!

@yue4u yue4u merged commit b141ca1 into dev-v3 Jun 10, 2024
6 checks passed
@yue4u yue4u deleted the chore/remove-downlevel-dts branch June 10, 2024 10:09
@0b5vr 0b5vr mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0b5vr 0b5vr 0b5vr approved these changes

Assignees

@yue4u yue4u

Labels
Breaking Change Choose wisely
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yue4u @0b5vr