Fix transparency issues with mtoon material #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
この変更が原因っぽくない？ |
で問題が再現できたので関係ないと思います。 1.0対応から発生していたのではないかと推測しています |
ke456-png
commented
Aug 28, 2023
Comment on lines
+797
to
+800
| #ifdef OPAQUE | ||
| diffuseColor.a = 1.0; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
OPAQUEフラグを参照するように修正しました
There was a problem hiding this comment.
説明: opaque_fragment （もともと output_fragment ）チャンクで使われていた OPAQUE 定数がコード内で使われていなかった。定数自体は定義されているので、これをそのまま利用する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1266