Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type coupling between core and extract #7120

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Conversation

bigtimebuddy
Copy link
Member

Bug

This type issue happens when using @pixi/core without installing @pixi/extract.

node_modules/@pixi/core/index.d.ts:13:43 - error TS7016: Could not find a declaration file for module '@pixi/extract'. '/node_modules/@pixi/extract/lib/extract.js' implicitly has an 'any' type.
  Try `npm install @types/pixi__extract` if it exists or add a new declaration (.d.ts) file containing `declare module '@pixi/extract';`

13 import type { Extract as Extract_2 } from '@pixi/extract';

Description

CanvasExtract was removed in #6503 as a property of CanvasRenderer. This make this change consistent with Renderer and Extract. The extract property is redundant with plugins.extract and unnecessary. It also create an undesirable dependency between core with extract.

@bigtimebuddy bigtimebuddy requested a review from Zyie January 3, 2021 04:44
@bigtimebuddy bigtimebuddy added this to the v6.0.0 milestone Jan 3, 2021
@codecov-io
Copy link

Codecov Report

Merging #7120 (b3c885a) into main (13b7c21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #7120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b7c21...b3c885a. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jan 3, 2021
@bigtimebuddy bigtimebuddy merged commit 83c9bf6 into main Jan 3, 2021
@bigtimebuddy bigtimebuddy deleted the fix-extract branch January 3, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants