Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis package jsdoc #7087

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Basis package jsdoc #7087

merged 1 commit into from
Dec 21, 2020

Conversation

jasonsturges
Copy link
Contributor

Perhaps this started out as Basis Universal, then became basisLibrary?

This library is the only basisu keyword at npm, defined in basis package.json

Set JSDoc param basisu to type BasisBinding named basisLibrary

Minor typo (ignored from JSDoc): anothor => another

@codecov-io
Copy link

Codecov Report

Merging #7087 (978520a) into dev (cef1bd9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7087   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef1bd9...978520a. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 21, 2020
@bigtimebuddy bigtimebuddy merged commit 33b9de6 into pixijs:dev Dec 21, 2020
@jasonsturges jasonsturges deleted the jsdoc/basis-package branch December 21, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants