Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLEAR_MODES docs #7075

Merged
merged 8 commits into from
Dec 24, 2020
Merged

Improve CLEAR_MODES docs #7075

merged 8 commits into from
Dec 24, 2020

Conversation

ivanpopelyshev
Copy link
Collaborator

As discussed with @SukantPal , I have to clarify this once more.

Most people that write filters dont know about clamping and other tricks that are needed in case we use pow2 temporary renderTextures. Even our BlurFilter is affected, @GoodBoyDigital wrote this version for v5 :)

For them, we distinguish two clearing modes - one CLEAR that clears everything, and second BLIT that just overwrites new content over texture, and leaves right and bottom zone as it was.

@ShukantPal
Copy link
Member

@ivanpopelyshev BLIT mode doesn't not clear only the filtering area on the texture right now. If that was the intended purpose, we need to fix it.

@bigtimebuddy
Copy link
Member

I find this doc change not particularly useful or legible. This need some editing for clarity.

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #7075 (7b27585) into dev (3f04834) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7075   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f04834...7b27585. Read the comment docs.

@ShukantPal ShukantPal self-requested a review December 21, 2020 00:14
Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bigtimebuddy, I had a chat with @ivanpopelyshev and we cleared up (get it?) what CLEAR_MODES.BLIT should be doing. It basically skips clearing the filter texture if the filter has state.blend = false - as that will overwrite pixels anyway. Setting forceClear on the FilterSystem will make this mode clear regardless of the blend mode. That flag may be used in the future to force clearing on devices where that operation makes things faster.

Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub has a bug :(

@bigtimebuddy bigtimebuddy added this to the v6.0.0 milestone Dec 23, 2020
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 24, 2020
@bigtimebuddy bigtimebuddy merged commit cf20c00 into dev Dec 24, 2020
@bigtimebuddy bigtimebuddy deleted the docs-clearMode branch December 24, 2020 03:36
@bigtimebuddy
Copy link
Member

Thank you @SukantPal and @ivanpopelyshev for making this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants