Add overridable TextMetrics.isBreakingSpace for better CJK plugin support #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #7023 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 671 671
=========================================
Hits 671 671 Continue to review full report at Codecov.
|
packages/text/src/TextMetrics.ts
Outdated
| * @return {boolean} True if whitespace, False otherwise. | ||
| */ | ||
| private static isBreakingSpace(char: string): boolean | ||
| private static isBreakingSpace(char: string, _nextChar?: string): boolean |
| const reg = /[あいうえお]/; | ||
|
|
||
| // override breakingSpace | ||
| TextMetrics.isBreakingSpace = function (char, nextChar) |
There was a problem hiding this comment.
After this test is over, can you reset isBreakingSpace to the default. Otherwise it may have unintended side effects for other tests.
|
@bigtimebuddy thank you for the review. I have updated the code 😊 |
bigtimebuddy
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Code works for me! Thanks for the test too. I'll defer to @themoonrat to evaluate the utility of this.
themoonrat
requested changes
Nov 23, 2020
themoonrat
approved these changes
Nov 23, 2020
bigtimebuddy
added
the
✅ Ready To Merge
bigtimebuddy
changed the title
|
Thank you @huang-yuwei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As the discussion with @themoonrat in #6975, suggest allowing the
isBreakingSpaceto be able to receive thenextCharfor solving the CJK issues in adding additions.For example, the example plugin(https://codepen.io/huang-yuwei/pen/GRqbEmm) shows how we can solve the #6975 and #4447 via an adding addition.
However, I am not 100% sure whether the CJK related issues should be solved directly in PIXI.js itself.
Therefore, suggest applying the additional parameters for other developers can change via other plugins.
Pre-Merge Checklist
npm run lint)npm run test)