Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid creating new view in WebGPU #10875

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: avoid creating new view in WebGPU #10875

merged 2 commits into from
Aug 22, 2024

Conversation

GoodBoyDigital
Copy link
Member

Description of change

After trying out the WebGPU debugger, it showed that we createView each time a render target is bound. Tweaked it to use the getTextureView instead. This way we don't create a new view each time!

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

github-actions[bot]
github-actions bot reviewed Aug 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Aug 20, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9d79db:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title Update GpuRenderTargetAdaptor.ts fix: avoid creating new view in WebGPU Aug 21, 2024
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Aug 21, 2024
@Zyie Zyie added this pull request to the merge queue Aug 22, 2024
Merged via the queue into dev with commit 123cbbc Aug 22, 2024
5 checks passed
@Zyie Zyie deleted the chore/reuse-texture-view branch August 22, 2024 15:20
Zyie added a commit that referenced this pull request Aug 23, 2024
@Zyie
Revert "Update GpuRenderTargetAdaptor.ts (#10875)"
4c3a781 
This reverts commit 123cbbc.
@Zyie Zyie mentioned this pull request Aug 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
@Zyie
Revert "Update GpuRenderTargetAdaptor.ts (#10875)" (#10883)
19373af 
This reverts commit 123cbbc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodBoyDigital @Zyie