Merge pull request #535 from pixijs/520-bug-events-on-a-sprite-dont-w…

…ork-on-initial-run-using-vite Restore `draw` method being run for `<graphics>` components
pixijs · Sep 1, 2024 · e808f22 · e808f22
2 parents 86b833d + f7a0eb7
commit e808f22
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/constants/PixiReactIgnoredProps.ts b/src/constants/PixiReactIgnoredProps.ts
@@ -1,3 +1,6 @@
 import { PixiToReactEventPropNames } from './EventPropNames';
 
-export const PixiReactIgnoredProps = Object.freeze(Object.keys(PixiToReactEventPropNames));
+export const PixiReactIgnoredProps = Object.freeze([
+    ...Object.keys(PixiToReactEventPropNames),
+    'draw',
+]);
diff --git a/src/helpers/createInstance.ts b/src/helpers/createInstance.ts
@@ -1,4 +1,5 @@
 import { ReactToPixiEventPropNames } from '../constants/EventPropNames';
+import { PixiReactIgnoredProps } from '../constants/PixiReactIgnoredProps';
 import { applyProps } from './applyProps';
 import { catalogue } from './catalogue';
 import { convertStringToPascalCase } from './convertStringToPascalCase';
@@ -30,7 +31,7 @@ export function createInstance(
     // Get the class from an imported Pixi.js namespace
     const PixiComponent = catalogue[name];
 
-    const pixiProps = gentleCloneProps(props);
+    const pixiProps = gentleCloneProps(props, PixiReactIgnoredProps);
 
     // Clone event props
     Object.entries(props).forEach(([key, value]) =>

diff --git a/src/helpers/gentleCloneProps.ts b/src/helpers/gentleCloneProps.ts
@@ -1,4 +1,3 @@
-import { PixiReactIgnoredProps } from '../constants/PixiReactIgnoredProps';
 import { ReactIgnoredProps } from '../constants/ReactIgnoredProps';
 import { gentleClone } from './gentleClone';
 
@@ -8,5 +7,5 @@ export function gentleCloneProps(
     additionalIgnoredProps: readonly string[] = [],
 )
 {
-    return gentleClone(props, ReactIgnoredProps.concat(PixiReactIgnoredProps, additionalIgnoredProps));
+    return gentleClone(props, ReactIgnoredProps.concat(additionalIgnoredProps));
 }