Avoid error class name mangling in webpack #4768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussion
Webpack is mangling the names due to
concatenateModules
, but we can't expect them to be stable.concatenateModules
currently only saves a few KBs (1.09MB -> 1.05MB), so it's not worth keeping it.Alternative solutions:
Err {name = 'Err'; static name = 'Err'}
new
on themFuture solution:
pixiebrix-extension/src/errors/errorHelpers.ts
Lines 215 to 217 in 65427ee
Checklist