browser polyfill cleanup, debugging improvements
#3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jun 8, 2022
| if (!("browser" in globalThis)) { | ||
| // @ts-expect-error For debugging only | ||
| globalThis.browser = browser; | ||
| } |
There was a problem hiding this comment.
This lets us finally use browser.* APIs in the console.
pageScript also has a similar jQuery global, so I thought I'd expose that too.
| @@ -33,7 +32,7 @@ export async function ensureAuth( | |||
| } | |||
|
|
|||
| try { | |||
| const token = await chromeP.identity.getAuthToken({ | |||
| const token = await browser.identity.getAuthToken({ | |||
There was a problem hiding this comment.
chromeP was only ever used because browser lacked the types. I fixed this a while ago:
| await browser.tabs.reload(browser.devtools.inspectedWindow.tabId); | ||
|
|
||
| browser.runtime?.reload(); // Not guaranteed |
There was a problem hiding this comment.
If we request the reload, browser.tabs becomes unavailable, so the rest fails.
| @@ -15,11 +15,10 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| const { tabId } = chrome.devtools.inspectedWindow; | |||
There was a problem hiding this comment.
This was inexplicably providing a tabId global type available in every file. 😰
Mysteries of TypeScript.
| this.status = status; | ||
| Object.setPrototypeOf(this, Error.prototype); |
There was a problem hiding this comment.
Remnant of pre-class X extends Error times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes I made along the way that didn't fit anywhere else. Details in the commits title and in the reviews