Bump serialize-error from 9.1.1 to 10.0.0 #3246
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
Codecov Report
@@ Coverage Diff @@
## main #3246 +/- ##
==========================================
- Coverage 35.27% 35.24% -0.04%
==========================================
Files 738 738
Lines 21102 21086 -16
Branches 4522 4518 -4
==========================================
- Hits 7444 7431 -13
+ Misses 12737 12735 -2
+ Partials 921 920 -1
Continue to review full report at Codecov.
|
|
@dependabot rebase |
Bumps [serialize-error](https://github.com/sindresorhus/serialize-error) from 9.1.1 to 10.0.0. - [Release notes](https://github.com/sindresorhus/serialize-error/releases) - [Commits](sindresorhus/serialize-error@v9.1.1...v10.0.0) --- updated-dependencies: - dependency-name: serialize-error dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/serialize-error-10.0.0
branch
from
5450bf7 to
067af89
Compare
There was a problem hiding this comment.
You can see the changes I made to serialize-error here: https://github.com/sindresorhus/serialize-error/releases/tag/v10.0.0
| return { | ||
| error: serializeError(error), | ||
| error: serializeError(error, { useToJSON: false }), |
There was a problem hiding this comment.
Thanks to:
Unfortunately we can only make use of this feature when calling serializeError directly. Since webext-messenger calls serializeError internally, we can't guarantee that toJSON is ignored everywhere, so other delete axiosError.toJSON calls will have to be preserved.
| @@ -289,66 +282,39 @@ export function getRootCause(error: ErrorObject): ErrorObject { | |||
| return error; | |||
| } | |||
|
|
|||
| // Manually list subclasses because the prototype chain is lost in serialization/deserialization | |||
| // See https://github.com/sindresorhus/serialize-error/issues/48 | |||
| const BUSINESS_ERROR_CLASSES = new Set([ | |||
There was a problem hiding this comment.
Dropped because it just duplicates the string set below. Once we fix the circular-reference issue we can use this set instead of the strings set.
| // List all BusinessError subclasses as text: | ||
| // - to avoid circular reference issues | ||
| // - because not all of our errors can be deserialized with the right class: | ||
| // https://github.com/sindresorhus/serialize-error/issues/72 |
There was a problem hiding this comment.
Subclass support is only possible if the constructor is compatible, but some of our constructors aren't:
So I'll look into using the correct constructor separately.
| return ( | ||
| isErrorObject(error) && | ||
| (BUSINESS_ERROR_NAMES.has(error.name) || hasBusinessRootCause(error.cause)) | ||
| ); |
There was a problem hiding this comment.
Main changes:
- isErrorObject already includes a null check
- any error can now have a
cause, so we don't need to limit this recursiveness to Context Errors
Bumps serialize-error from 9.1.1 to 10.0.0.
Release notes
Sourced from serialize-error's releases.
Commits
6f6102f10.0.022b9bd4Require Node.js 1449db63aPreserve error constructor (#70)bdf7ad4Deserialize nested errors (#69)e9e8666AdduseToJSONoption (#71)392081cMinor tweaksbb6d9d6AddisErrorLike()method (#68)adc780dFix.toJSON()example7e8be51Add support forcauseproperty (#65)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)