Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chromatic during CI #5262

Closed
twschiller opened this issue Feb 27, 2023 · 5 comments
Closed

Add support for Chromatic during CI #5262

twschiller opened this issue Feb 27, 2023 · 5 comments

Comments

@twschiller
Copy link
Contributor

Context

Reference

@BLoe
Copy link
Contributor

BLoe commented Jun 27, 2023

@grahamlangford I'm curious how this relates to Storyshots in Jest? Is this a better option? Something different? We've also started using Rainforest a lot more since this ticket was written.

@grahamlangford
Copy link
Collaborator

@grahamlangford I'm curious how this relates to Storyshots in Jest? Is this a better option? Something different? We've also started using Rainforest a lot more since this ticket was written.

@BLoe Chromatic is a full VRT, so it's rather different than Storyshots. It might be worth pursuing later, especially if we start using Storybook more. I would keep this around in the Icebox for now.

Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label Jan 24, 2024
@grahamlangford
Copy link
Collaborator

We're not even fully using Storybook. This would be nice to implement eventually, but not worth keeping around now.

@twschiller
Copy link
Contributor Author

We're not even fully using Storybook. This would be nice to implement eventually, but not worth keeping around now.

Agree to close for now. Part of the reason we're not fully using Storybook is that the value of maintaining doesn't seem to be there at the moment. Having Chromatic in place would make Storybook more valuable for quality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants