-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fat clock font #169
Fat clock font #169
Conversation
Nice PR! What about only a "fat clock"-option? Then only some numbers a needed and less changes of the other code? |
Sorry, I don't quite follow? Do you mean don't do the date bit and just make it so that Big Clock Font is not compatible with the alternating date feature? If so - could do, but it wouldn't really make that much difference in terms of code. I've edited my comment very slightly - it doesn't change much in terms of existing code, apart from a few "if"s in the clock string build and rendering. It's mostly adding new stuff just to support this new number style. |
Oh I think perhaps I get what you mean! It is only a fat clock font. The notification stuff is unchanged. I will make that clearer! |
Hi and thanks for your PR, I will definitely look at that and test. |
Although the characters "A" and "P" aren't rendered, the space (" ") is, which nudges the text over making it misaligned. This change fixes that.
Thank you for contribution :) |
You're really welcome, thanks for accepting my PR, and I'm sorry you had to spend time fixing the json (and lots of formatting...clearly your standards are higher than mine!) |
This change implements a big fat clock font font for better readability / more impact - intended really for situations where there's a big bezel and the individual pixels are hidden - so there's no need for any whitespace within the matrix, might as well use all the pixels! Basically I wanted a really big, fat time display :)
In doing so it has to make a few additions:
@o0shojo0o - I appreciate this is quite a big change. If it doesn't match where you want the project to go that's fine, reject the change and I'll keep my fork alive. If you do accept - I've updated the .vue for the webUI but I don't believe I can actually compile it and commit the new version because it's linked to your github. You will also definitely want to look through the change to the webUI to make sure it works as expected as I haven't been able to test it.