Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine centerText with scrollText=auto #96

Closed
miccgn opened this issue Dec 10, 2021 · 7 comments
Closed

Combine centerText with scrollText=auto #96

miccgn opened this issue Dec 10, 2021 · 7 comments
Labels
backlog enhancement New feature or request

Comments

@miccgn
Copy link
Contributor

miccgn commented Dec 10, 2021

It would be a nice enhancement if I could specify both "centerText=true" and "scrollText=auto".

Expected behaviour:

  • if text fits into display: center it, no scrolling
  • if text does not fit into display: ignore centering, start scrolling

Difference to now is that text that fits will be centered, not adjusted left.

I have some ideas how to do this, but this requires redesign of all the DrawText... functions.

@o0shojo0o
Copy link
Member

Yes, it would have to completely rebuild DrawText.
But I couldn't motivate myself to do it yet.
I had started it once before, but discarded it due to lack of time.

@poblabs
Copy link

poblabs commented Jan 13, 2022

+1 on this one from me too. Having a bitmap and animation, would be nice to have text start centered, then scroll while keeping bitmap. Thanks!

@o0shojo0o o0shojo0o added the enhancement New feature or request label May 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale This issue has been automatically marked as stale because it has not had recent activity. label Sep 4, 2023
@miccgn
Copy link
Contributor Author

miccgn commented Sep 5, 2023

Still would be an useful extension

@github-actions github-actions bot removed the stale This issue has been automatically marked as stale because it has not had recent activity. label Sep 6, 2023
@foorschtbar
Copy link
Member

@foorschtbar
Copy link
Member

foorschtbar commented Sep 23, 2023

Implemented in latest (2.3.2) release

@miccgn
Copy link
Contributor Author

miccgn commented Sep 23, 2023

Thanks!
Sorry, didn't find time to test it yet 😕😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants