-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syfmony 5 support #90
base: master
Are you sure you want to change the base?
Conversation
Is there any provision to merge this pull request soon. |
Hi @bhaktaraz Thank you for the Pull Request. Why not also using Autowiring for the Translator in
|
@TheFox, yeah, sure, this would make sense. But this can easily be another PR since this one is focused on migrating to symfony 5. Using DI for the translator is an optional change here. I am also not sure if it will ever get merged. This PR is more than a year old and we're "living" off our fork atm. |
@nicolasricci Can you please take a look? |
@ottaviano merge this please! |
@spolischook, I'm not a maintainer of this repo, btw I'm waiting too for this PR :D |
Sonata admin officially migrated to |
Fixed everything to support symfony 5.x and the upcoming sonata/admin 4.x versions.