Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syfmony 5 support #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Syfmony 5 support #90

wants to merge 2 commits into from

Conversation

toooni
Copy link

@toooni toooni commented Feb 27, 2021

Fixed everything to support symfony 5.x and the upcoming sonata/admin 4.x versions.

@bhaktaraz
Copy link

Is there any provision to merge this pull request soon.

@TheFox
Copy link

TheFox commented May 12, 2022

Hi @bhaktaraz

Thank you for the Pull Request.

Why not also using Autowiring for the Translator in \Pix\SortableBehaviorBundle\Controller\SortableAdminController ?

$translator = $this->get('translator');

@toooni
Copy link
Author

toooni commented May 12, 2022

@TheFox, yeah, sure, this would make sense. But this can easily be another PR since this one is focused on migrating to symfony 5. Using DI for the translator is an optional change here.

I am also not sure if it will ever get merged. This PR is more than a year old and we're "living" off our fork atm.

@toooni
Copy link
Author

toooni commented May 12, 2022

@nicolasricci Can you please take a look?

@spolischook
Copy link

@ottaviano merge this please!

@ottaviano
Copy link

@spolischook, I'm not a maintainer of this repo, btw I'm waiting too for this PR :D

@dmitryuk
Copy link

Sonata admin officially migrated to runroom-packages/sortable-behavior-bundle, try it instead (Symfony 5 already supported).
https://symfony.com/bundles/SonataAdminBundle/current/cookbook/recipe_sortable_listing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants