Closes #51 : Added index.d.ts + documentation for javascript and typescript #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better example in doc hid callback_type type
Better example in doc
js example instead of ts
Provided typescript examples also a getting-cow-names example was missing.
doc update
lachieh
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
This all looks good to be, aside from a few the y and w being switched in some of the examples. I'm not the owner but I have confirmed that this file works as expected. I appreciate the updated readme with examples too.
@piuccio if you're good with the README.md changes, this is good from a TS perspective.
Comment on lines
+135
to
+136
| * - #### `w` : youthful | ||
| * - #### `y` : wired |
There was a problem hiding this comment.
Suggested change
| * - #### `w` : youthful | |
| * - #### `y` : wired | |
| * - #### `w` : wired | |
| * - #### `y` : youthful |
Co-authored-by: Lachlan Heywood <[email protected]>
piuccio
approved these changes
Feb 25, 2021
ofarukcaki
pushed a commit
to ofarukcaki/cowsay
that referenced
this pull request
Jul 29, 2023
…nd typescript (piuccio#59) Co-authored-by: Lachlan Heywood <[email protected]>
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51 : Added
index.d.ts+ documentation for Javascript and Typescript