Allow empty container_map #243
Conversation
Fixes dfw exiting immediately if no containers are running.
|
@Georgiy-Tugai thanks for your PR! While the change itself is very simple, I will have to re-familiarize myself with the surrounding logic to see if this makes sense as is. Right off the bat though I think the change itself makes sense, although I think the return-type of the function should be changed, which would get rid of the |
|
That's OK! I have almost zero experience with Rust, so I didn't want to mess with the function's return type. 😄 I've tested this on my small Docker deployment and it seems to work fine so far, for what it's worth. |
267: Remove special handling for empty container_map r=pitkley a=pitkley DFW can be used without any containers running, given that it performs various actions that are not specific to a running container (managing default policies, handling custom initialization rules). Thanks to @Georgiy-Tugai for the initial pull-request! Closes #243. Co-authored-by: Georgiy Tugai <[email protected]> Co-authored-by: Pit Kleyersburg <[email protected]>
|
Hey @Georgiy-Tugai, thanks again for the contribution. I have taken a look at the change and it definitely made sense! Since I performed some refactorings between when you created the PR and now, I have created a separate PR and included your change in 552e6de (and I took the opportunity to modify the return-type). This change will be part of v1.2.0. 👍 |
Fixes dfw exiting immediately if no containers are running.