Always recreate mocks inside of setup-mocks
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test case in scope - Commit correct version for `package-lock.json` since I forgot before
ottonascarella
approved these changes
May 25, 2023
jo-sm
added a commit
that referenced
this pull request
Jun 19, 2023
A regression was caused by #28, such that the original binding values would be called when put back (due to the change to always reinstantiate the mocks for each test case). This wasn't covered by the tests and for non-side-effecting functions, this wouldn't surface, but for non-functions and for side-effecting functions, calling the original function could cause issues. This commit fixes that by wrapping the original binding values in functions just like the mocks. This commit also adds some useful comments and renames binding symbols since every time I look at `with-scoped-redefs` I get confused since the function was basically copied from `with-redefs`, and the naming there is a bit terse. Fixes #44.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
setup-mocksbug which caused the bindings to not always be recreated for each test case, instead only being created once and being reused. This allowssetup-mocksto be used in cases where something stateful is being mocked, such as a JS class instance.