Simplify matcher setup and fix bug related to negated matchers #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving more of the logic into the compile stage, it's possible to simplify a lot of the internals related to matchers. Specifically, instead of setting the dynamic `*inside-is?` and `*is-body-negated?` bindings inside of `cljest.core/is` and reading these values inside of `cljest.matchers/make-matcher` and `make-optional/matcher`, which created an implicit contract between the two, we have a `defmatcher` macro which generates a function that has explicit `:jest-matcher` metadata which is analyzed at compile time. This lets all of the `expect` code exist within `is`, making it easier to reason about how things work at the expense of more things moving to compile time. Additionally, the previous implementation did not correctly support negated matchers, and was only discovered after some manual testing and exploration. This change fixes this bug. - Support alises when running cljest Previously, if you had an alias such as `test` which you were starting `clj` with, while the code would correctly compile, but Jest wouldn't find any extra paths that alias added.
jo-sm
force-pushed
the
simplified-matchers
branch
from
a7a96f3 to
325bd84
Compare
- Use `cljest__is` matcher directly rather than `cljest.core/is-matcher` in `is` macro
- Update changelog (including previous missing `setup-mocks` fix)
jo-sm
force-pushed
the
simplified-matchers
branch
from
325bd84 to
e668d83
Compare
ottonascarella
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way matchers are defined by creating the macro
defmatcher, which creates a function with metadata that can be analyzed at compile time to know if the defined function is a matcher. This has benefits both related to simplicity, as all of theexpectrelated code now lives incljest.core/isand related internal macros, as well as allowing external users to define their own matchers without needing to commit them to the main repo.Additionally, support for aliases is added to that Jest will correctly use them when calling
clojure -Spathto get the class path.TODOs
resolved-infomapismacro to not use non-macro code internally (useexpectdirectly)