Fix async with multiple let bindings
#30
Labels
bug
Something isn't working
Comments
jo-sm
added a commit
that referenced
this issue
Jun 1, 2023
Previously, the `async` macro would attempt to treat a non-symbol form as a function call
and so the following would result:
```
(h/async
(let [result (await (js/Promise.resolve "value"))]
...))
;; Compiles into...
var xyz = Promise.resolve("value").call()
```
This commit fixes this so that let bindings are properly created.
- Remove macroexpansion from tests
With the correct let binding handling, macroexpansion doesn't work because the resulting
binding names are random (something like v_51003, p_40892), which can't really be equated.
Since we can test the `async` macro directly we can just remove the macroexpansion tests
completely.
Fixes #30, #31.
jo-sm
added a commit
that referenced
this issue
Jun 1, 2023
Previously, the `async` macro would attempt to treat a non-symbol form as a function call
and so the following would result:
```
(h/async
(let [result (await (js/Promise.resolve "value"))]
...))
;; Compiles into...
var xyz = Promise.resolve("value").call()
```
This commit fixes this so that let bindings are properly created.
- Remove macroexpansion from tests
With the correct let binding handling, macroexpansion doesn't work because the resulting
binding names are random (something like v_51003, p_40892), which can't really be equated.
Since we can test the `async` macro directly we can just remove the macroexpansion tests
completely.
Fixes #30, fixes #31.
jo-sm
added a commit
that referenced
this issue
Jun 1, 2023
Previously, the `async` macro would attempt to treat a non-symbol value for a binding
in a `let` as a function call and so the following would happen:
```
(h/async
(let [result (await (js/Promise.resolve "value"))]
...))
;; Compiles into...
var xyz = Promise.resolve("value").call()
```
This commit fixes this so that `await`-ed `let` bindings are properly handled.
- Remove macroexpansion from tests
With the correct let binding handling, macroexpansion doesn't work because the resulting
binding names are random (something like v_51003, p_40892), which can't really be equated.
Since we can test the `async` macro directly we can just remove the macroexpansion tests
completely.
Fixes #30, fixes #31.
jo-sm
added a commit
that referenced
this issue
Jun 1, 2023
Previously, the `async` macro would attempt to treat a non-symbol value for a binding
in a `let` as a function call and so the following would happen:
```
(h/async
(let [result (await (js/Promise.resolve "value"))]
...))
;; Compiles into...
var xyz = Promise.resolve("value").call()
```
This commit fixes this so that `await`-ed `let` bindings are properly handled.
- Remove macroexpansion from tests
With the correct let binding handling, macroexpansion doesn't work because the resulting
binding names are random (something like v_51003, p_40892), which can't really be equated.
Since we can test the `async` macro directly we can just remove the macroexpansion tests
completely.
Fixes #30, fixes #31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
asyncisn't working with multipleletbindings if any later binding uses an earlier one:This will fail because we internally turn that into
Promise.all, so we need to be smarter and handle each binding based on if they areawait-ed or not.The text was updated successfully, but these errors were encountered: