Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files #195

Merged
merged 4 commits into from
Jul 23, 2023
Merged

Files #195

merged 4 commits into from
Jul 23, 2023

Conversation

quojama
Copy link
Member

@quojama quojama commented Jul 22, 2023

  • ファイルの移動と削除
  • DBに追加と削除するためのやつをシェルでrye runでいけるように

@quojama quojama requested a review from zztkm July 22, 2023 20:05
Copy link
Member

@zztkm zztkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with IMO

pyproject.toml Outdated
Comment on lines 40 to 41
add = "sudo python3 scripts/db_insert_data.py"
delete = "sudo python3 scripts/db_delete_data.py"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[imo]
もし、サーバーの方に rye もインストールする前提でしたら以下のように書くほうが良いかも 🤔

add = "python scripts/db_insert_data.py"
delete = "python scripts/db_delete_data.py"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そっかー、サーバーで使う想定だったけどそもそもrye入ってないのか

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サーバーに rye 入れちゃえばいいだけでは??

@quojama quojama merged commit 45b88e9 into main Jul 23, 2023
1 check passed
@quojama quojama deleted the files branch July 23, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢💨Shipped
Development

Successfully merging this pull request may close these issues.

2 participants