Medium-scale refactoring #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - smart_open_lib.py was cluttered - parsing logic was messy Main changes: - smart_open.parse_uri is now a publicly available function - Parsers for the individual schemes, e.g. HDFS, S3 now live in the corresponding submodule - Moved compression to a separate submodule I haven't changed any of the unit tests, in order to demonstrate that everything still works as expected from the outside.
piskvorky
approved these changes
Jan 11, 2020
Closed
|
@piskvorky @menshikh-iv I've made more changes and made sure the build passes. Can you please re-review? |
piskvorky
reviewed
Mar 27, 2020
menshikh-iv
reviewed
Mar 27, 2020
|
|
||
| You can confirm the documentation changes by running: | ||
|
|
||
| python -c 'help("smart_open")' |
There was a problem hiding this comment.
link to submodule should be here, I guess?
| @@ -0,0 +1,132 @@ | |||
| # Extending `smart_open` | |||
|
|
|||
| This document targets potential contributors to `smart_open`. | |||
There was a problem hiding this comment.
What's about actions in case if I want to add new format, but without pushing them to smart_open (for example, reader for proprietary stuff in the company, useless for open-source).
|
Amazing work @mpenkov ⭐ |
isobit
added a commit
to isobit/smart_open
that referenced
this pull request
Jul 20, 2020
Fixes: - piskvorky#391 - piskvorky#409 Related to: - piskvorky#413 - piskvorky#468 - piskvorky#408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Main changes:
corresponding submodule
I haven't changed any of the unit tests, in order to demonstrate that
everything still works as expected from the outside.
Checklist
Before you create the PR, please make sure you have: