Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using Annoy as an external similarity index #774

Merged
merged 6 commits into from
Jul 6, 2016
Merged

Add support for using Annoy as an external similarity index #774

merged 6 commits into from
Jul 6, 2016

Conversation

droudy
Copy link
Contributor

@droudy droudy commented Jul 6, 2016

(Related to #617, #527, and #51.)

Implementation + tests + tutorial

@droudy droudy changed the title Add support for using Annoy as an external similarity Add support for using Annoy as an external similarity index Jul 6, 2016
@tmylk tmylk merged commit 4ce3ce1 into piskvorky:develop Jul 6, 2016
@tmylk
Copy link
Contributor

tmylk commented Jul 6, 2016

Thanks for the PR to @droudy and @karlhigley!

"cell_type": "markdown",
"metadata": {},
"source": [
"This tutorial is about using the Annoy(Approximate Nearest Neighbors Oh Yeah) library for similarity queries in gensim"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hyperlink to Annoy here.

@piskvorky
Copy link
Owner

Nice functionality! Thank you. I added comment for fixing a few minor typos.

@tmylk I'd still add some conclusions / CTA section at the end. The ending reads a little weird.

"metadata": {},
"source": [
"### Using the SimilarityIndex class\n",
"An instance of `SimilarityIndex` needs to be created in order to use Annoy in gensim. The `SimilarityIndex` class is located in `gensim/similarities/index`\n",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's meant to be a filesystem path, use extension too (and perhaps even hyperlink).

@droudy droudy deleted the annoy branch July 11, 2016 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants