[WIP] Add support for using Annoy as an external similarity index #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
force-pushed
the
annoy
branch
2 times, most recently
from
2816523 to
a943f08
Compare
|
@tmylk: I had a bit of trouble with Doc2Vec during the sprints, but I think I figured out a way to do it. |
|
Implemented in #784 and others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Related to #617, #527, and #51.)
This is a partial implementation of an external similarity index based on Annoy for approximate nearest neighbor search. It's based on #617 and the related comments, using a test-first approach. I'm running out of time to pursue it during the PyCon sprints, but wanted to share the pieces that may be useful for pushing #617 forward (e.g. class method index construction, conditional Annoy dependency in the tests).