-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpy 2.0.0 update and removing deprecated scipy modules #3562
base: develop
Are you sure you want to change the base?
Conversation
@mpenkov @gojomo @piskvorky could you run the CI on this and see if this works fine? |
Done :) |
@piskvorky argh the linter :D |
@piskvorky could you re-trigger? Or is there a way how I can execute test in a way that is comparable to the CI? |
@hechth @YoungMind1 Thanks for looking into this! Edit: Sorry... Realized scipy 1.14 requires python 3.10 too late. Forget it, maybe in a later version. |
Upgrading numpy will fail tests, since saving in word2vec format will save keyvectors as strings of numpy datatypes instead of strings of floats. |
This PR is an initial attempt at porting the project to numpy 2.0.0 - so far running the tests manually after installing all dependencies seemed fine. I removed the deprecated scipy sparse functions and replaced them with the normal operator versions.