Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import deprecated scipy.linalg.triu from numpy.triu instead #3524

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Import deprecated scipy.linalg.triu from numpy.triu instead #3524

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a85d1f
Removing Import of depecrated triu function imported from scipy lib
Luffy610 Apr 3, 2024
7a10528
Merge pull request #1 from Luffy610/bugfix/scipy-import-bug
Luffy610 Apr 3, 2024
9b47dad
Importing triu from numpy if failed falling back to scipy
Luffy610 Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gensim/matutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import numpy as np
import scipy.sparse
from scipy.stats import entropy
from scipy.linalg import get_blas_funcs, triu
from scipy.linalg import get_blas_funcs
from scipy.linalg.lapack import get_lapack_funcs
from scipy.special import psi # gamma function utils

Expand Down Expand Up @@ -1127,7 +1127,7 @@ def qr_destroy(la):
qr, tau, work, info = geqrf(a, lwork=work[0], overwrite_a=True)
del a # free up mem
assert info >= 0
r = triu(qr[:n, :n])
r = np.triu(qr[:n, :n])
Luffy610 marked this conversation as resolved.
Show resolved Hide resolved
if m < n: # rare case, #features < #topics
qr = qr[:, :m] # retains fortran order
gorgqr, = get_lapack_funcs(('orgqr',), (qr,))
Expand Down
Loading