Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle optional parameters without implicit bool cast #3502

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Handle optional parameters without implicit bool cast #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d6d25
Handle optional parameters without implicit bool cast
nk-fouque Oct 31, 2023
bc85e82
dummy commit to trigger CI
mpenkov Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,4 @@ BibTeX entry:
[OpenBLAS]: https://xianyi.github.io/OpenBLAS/
[source tar.gz]: https://pypi.org/project/gensim/
[documentation]: https://radimrehurek.com/gensim/#install

12 changes: 6 additions & 6 deletions gensim/models/tfidfmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,16 +360,16 @@ def __init__(self, corpus=None, id2word=None, dictionary=None, wlocal=utils.iden
self.pivot = pivot
self.eps = 1e-12

if smartirs:
if smartirs is not None:
n_tf, n_df, n_n = self.smartirs
self.wlocal = partial(smartirs_wlocal, local_scheme=n_tf)
self.wglobal = partial(smartirs_wglobal, global_scheme=n_df)

if dictionary:
if dictionary is not None:
# user supplied a Dictionary object, which already contains all the
# statistics we need to construct the IDF mapping. we can skip the
# step that goes through the corpus (= an optimization).
if corpus:
if corpus is not None:
logger.warning(
"constructor received both corpus and explicit inverse document frequencies; ignoring the corpus"
)
Expand All @@ -378,17 +378,17 @@ def __init__(self, corpus=None, id2word=None, dictionary=None, wlocal=utils.iden
self.dfs = dictionary.dfs.copy()
self.term_lens = {termid: len(term) for termid, term in dictionary.items()}
self.idfs = precompute_idfs(self.wglobal, self.dfs, self.num_docs)
if not id2word:
if id2word is None:
self.id2word = dictionary
elif corpus:
elif corpus is not None:
self.initialize(corpus)
else:
# NOTE: everything is left uninitialized; presumably the model will
# be initialized in some other way
pass

# If smartirs is not None, override pivot and normalize
if not smartirs:
if smartirs is None:
return
if self.pivot is not None:
if n_n in 'ub':
Expand Down