make gensim CI great again #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect the latest numpy and/or scipy wheels are the cause of the recent slowdown, because the tests that ran on 2023/06/01 against the versions that I'm pinning in this commit were much faster.
This was referenced Aug 23, 2023
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiled extension building.
pip 23.2.1 (and newer) runs build_ext on its own, using whatever cython is specified in pyproject.toml. If use use Cython 3.0.0 to build the compiled extensions, then they will be an order of magnitude slower (not sure why, but it's reproducible) so I'm pinning the Cython version to <3.0.0.
The separate build_ext step is no longer necessary; in fact, it was getting in the way because it doesn't respect pyproject.toml, so it may end up using an unwanted version of Cython.