git rm gensim/models/flsamodel.py

[mpenkov]

No description provided.

[piskvorky]

@mpenkov so we're axing the module? Either way, let me merge the FLSA PRs first.

In case someone wants to continue in the future, so that they have the "fixed" version, with the various improvements from the recent PRs by me and @ERijck.

[mpenkov]

Yes, I think it's best to remove this. It's completely new code, and we don't have the resources to maintain it (pace of existing PRs related to this module is extremely slow).

Let me know when it's ready to torch.

[ERijck]

That's unfortunate. But I understand your considerations. What needs to be changed so it meets the Gensim requirements later on? I understand that the main limitation now is the representation (strings instead of integer BOW); is that correct? Are you open to me fixing this issue and adding it to Gensim once ready?

Also, my Git understanding was lacking as this was my first project contributing to another repository. However, to solve this, I have followed the full Git course on Codecademy.

[piskvorky]

Are you open to me fixing this issue and adding it to Gensim once ready?

Yes, I am. The code is in much better shape already, after our recent PRs. If you can get its data representation in shape (same streaming input as the rest of Gensim, not everything in RAM) then I'll be happy to include FLSA.

For now, can you please fix #3437 (comment)? So we can merge that PR, it will be a starting point for any future revivals. Thanks!