-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point WordEmbeddingSimilarityIndex documentation to gensim.similarities #3003
Point WordEmbeddingSimilarityIndex documentation to gensim.similarities #3003
Conversation
Thanks @Witiko ! The main place for documentation is the gallery. I fear the Would it make sense to convert this into a gallery tutorial / howto script? With the notebook and html formats auto-generated from the converted source, instructions. |
@piskvorky I like the idea behind the gallery. I don't have the time to convert now, but I will take a look during the next week. |
@Witiko we're planning the 4.0 release now. Can you please finish this? Thanks. |
@piskvorky Thanks for the reminder. I will give it a look this weekend. |
@piskvorky Would it be OK to merge the SCM notebook with the WMD autoexample? This would rid us of a lot of duplication and there would exist a single lean and mean example for word-embedding-based document similarity measures. |
Anything that cleans up & simplifies documentation is highly desirable. @mpenkov WDYT? |
No objections from me. |
d4aa31c
to
15f9282
Compare
In the end, I kept the tutorials separate. Merging the tutorials seemed as a good idea at first, but the preprocessing pipelines for the SCM and the WMD are quite different and the merged tutorial would become significantly more complex as a result. Perhaps I can give it another stab if we are ever adding sections about |
Thanks so much @Witiko . Is the failing test related? |
@piskvorky I don't think it is. The failing test is for Doc2Vec, which this PR does not touch. |
I re-ran the tests, they all passed. |
Merged, thank you @Witiko ! |
Currently, all documentation, Jupyter notebooks and code examples assume that
WordEmbeddingSimilarityIndex
is located ingensim.models
, although it lives ingensim.similarities
since 4.0.0. This pull request fixes the documentation.