Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize
FastText.load_fasttext_model
#2340Optimize
FastText.load_fasttext_model
#2340Changes from 3 commits
e1b9ba0
53497a6
6ae0bb9
3406bf0
e458ff0
8144e20
d735099
fd32340
4e022d8
8e7bd40
2ea4672
9137a27
a654c3c
f392d80
4fd56d5
98d0a09
b614030
46e1ec1
d1b80c0
07c49c2
ccaba08
0b0e46e
cdab5b6
d13e4c9
a412e48
6617b80
da025d3
402db7d
bb7282d
8e72e18
07baf84
ce1a631
e87ca05
38146bd
136dc85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stupid question: what if self.trainables does not have
syn1neg
attr at all, so can model train ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I don't see any other code that sets syn1neg to None. So, the new code uses that value to mean "cannot continue training".
If trainables does not have syn1neg at all, it is possible to start training.