Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note about training mode in 'partial_fit' #1382

Merged
merged 5 commits into from
Jun 5, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gensim/sklearn_integration/sklearn_wrapper_gensim_ldamodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ def get_topic_dist(self, bow, minimum_probability=None, minimum_phi_value=None,
def partial_fit(self, X):
"""
Train model over X.
By default, 'online' mode is used for training the LDA model.
Configure `passes` and `update_every` params at init to choose the mode among 'online', 'mini-batch', 'batch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explicit values to use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the mode names and also added explicit values to use for each mode.

"""
if sparse.issparse(X):
X = matutils.Sparse2Corpus(X)
Expand Down