-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added save method for doc2vec #1256
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
989ee74
added save method fordoc2vec
parulsethi da3d566
change method name and add prefix
parulsethi 9660bd6
use keyedvectors save
parulsethi c8d4eed
changes as per @gojomo reviews
parulsethi d1a5e0b
added test
parulsethi b2d9319
modified CHANGELOG.md
parulsethi 441298d
expanded tests
parulsethi fcbf45d
added doc2vec tensorboard viz notebook
parulsethi 102f473
Merge branch 'develop' into save_doc2vec
parulsethi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ | |
import numpy as np | ||
|
||
from gensim import utils, matutils | ||
from gensim.models import doc2vec | ||
from gensim.models import doc2vec, keyedvectors | ||
|
||
module_path = os.path.dirname(__file__) # needed because sample data files are located in the same folder | ||
datapath = lambda fname: os.path.join(module_path, 'test_data', fname) | ||
|
@@ -76,6 +76,13 @@ def test_persistence(self): | |
model.save(testfile()) | ||
self.models_equal(model, doc2vec.Doc2Vec.load(testfile())) | ||
|
||
def testPersistenceWord2VecFormat(self): | ||
"""Test storing the entire model in word2vec format.""" | ||
model = doc2vec.Doc2Vec(DocsLeeCorpus(), min_count=1) | ||
model.save_word2vec_format(testfile(), doctag_vec=True, binary=True) | ||
binary_model_dv = keyedvectors.KeyedVectors.load_word2vec_format(testfile(), binary=True) | ||
self.assertEqual(len(model.wv.vocab) + len(model.docvecs), len(binary_model_dv.vocab)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add tests for more combinations of |
||
|
||
def test_load_mmap(self): | ||
"""Test storing/loading the entire model.""" | ||
model = doc2vec.Doc2Vec(sentences, min_count=1) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The potential to save the vocabulary, with particular index-positions that correspond to the word-vectors only, makes me think that when both word+doc vectors are stored, the word-vectors should go first. Then, at least, any vocab written aligns one-for-one with the word-vectors portion of the save file. (Also: does
fvocab
currently do anything in the save-both case?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, word-vectors go first now.
It didn't, earlier. But now that only
KeyedVectors.save_word2vec
is used for save-only-wv and save-both, vocab is saved in both the cases.