Fix #824 : no corpus in init, but trim_rule in init #1186
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logged warning that trim_rule is being ignored for separate model initialization and vocabulary building
gojomo
reviewed
Mar 7, 2017
| @@ -474,6 +474,11 @@ def __init__( | |||
| raise TypeError("You can't pass a generator as the sentences argument. Try an iterator.") | |||
| self.build_vocab(sentences, trim_rule=trim_rule) | |||
| self.train(sentences) | |||
|
|
|||
| else : | |||
There was a problem hiding this comment.
This warning even shows if no trim_rule specified – which seems excessive, as there's no hint that the user is confused in that case.
There was a problem hiding this comment.
@gojomo Thanks for pointing that out. I've updated the code accordingly.
|
Thanks for making this more clear to users! |
pranaydeeps
pushed a commit
to pranaydeeps/gensim
that referenced
this pull request
Mar 21, 2017
…ky#1186) * no corpus in init, but trim_rule in init logged warning that trim_rule is being ignored for separate model initialization and vocabulary building * log warning only when trim_rule is specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logged warning that trim_rule is being ignored for separate model initialization and vocabulary building. (#824)