Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDA hyperparameter fix: eta dimensionality and optimization #1024

Merged
merged 18 commits into from
Nov 29, 2016
Merged

LDA hyperparameter fix: eta dimensionality and optimization #1024

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
db64eeb
Copied ldamodel into ldamodel2. Going to make changes to ldamodel2 an…
olavurmortensen Nov 17, 2016
5557231
Fixed initialization of eta, and optimization of eta.
olavurmortensen Nov 17, 2016
7dee48d
Changed the name of both LDA versions, so that it is possible to see …
olavurmortensen Nov 17, 2016
e0cb079
Added a notebook with tests.
olavurmortensen Nov 17, 2016
baac8de
Added check of eta shape. Added check that eta is not 'asymmetric', r…
olavurmortensen Nov 18, 2016
dc35083
Updated lda unit tests. Expected dimensions of eta are now '(num_term…
olavurmortensen Nov 18, 2016
7045ea7
Just removed a print statement.
olavurmortensen Nov 18, 2016
a1190fa
Not logging eta, as it can be quite huge. Updates w.r.t. requested ch…
olavurmortensen Nov 28, 2016
8df642d
Re-introduced K x V asymmetric priors. Updated eta docstring.
olavurmortensen Nov 28, 2016
ce5b186
Reverted positivity of prior check to the way it was before.
olavurmortensen Nov 28, 2016
24b3967
Added a assertionRaise for asymmetric option of eta.
olavurmortensen Nov 28, 2016
6c61b3c
Removed an incorrect unit test. Added unit tests for K x V eta.
olavurmortensen Nov 28, 2016
6298621
Fixed indentation.
olavurmortensen Nov 28, 2016
0d33ac0
Added an assertRaises where eta is too long.
olavurmortensen Nov 28, 2016
b0e9c57
Removed temporary test notebook and old version of lda.
olavurmortensen Nov 28, 2016
66dad59
Removed import of old version of lda.
olavurmortensen Nov 28, 2016
bb0dfde
Removed unnecessary comments.
olavurmortensen Nov 29, 2016
013b5bb
Updated CHANGELOG.md
olavurmortensen Nov 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading