Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store images from README directly in repository #1849

Closed
menshikh-iv opened this issue Jan 22, 2018 · 4 comments
Closed

Store images from README directly in repository #1849

menshikh-iv opened this issue Jan 22, 2018 · 4 comments
Labels
difficulty easy Easy issue: required small fix documentation Current issue related to documentation good first issue Issue for new contributors (not required gensim understanding + very simple)

Comments

@menshikh-iv
Copy link
Contributor

Problem: We have adopters table that contains concrete companies with logo & additional information. Images (logo) stored everywhere (random CDN, sites, etc) -> can be broken (unavailable) -> README doesn't looks good.

Solution: Store all images in repository

Warning: We don't want to store large .jpg, all images should be optimized before.
@menshikh-iv menshikh-iv added documentation Current issue related to documentation difficulty easy Easy issue: required small fix good first issue Issue for new contributors (not required gensim understanding + very simple) labels Jan 22, 2018
@ibrahimsharaf
Copy link
Contributor

Hi @menshikh-iv, I am willing to take this one.
Should the images be stored in a separate directory in gensim repo? How big exactly is the large .jpg image?

@menshikh-iv
Copy link
Contributor Author

@ibrahimsharaf

  1. Yes, separate dir in docs/ is good choice
  2. As small as possible (preferred .png if available, .jpg is OK too).

@ibrahimsharaf
Copy link
Contributor

@menshikh-iv Do you have a specific image optimization method in mind?

@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Jan 23, 2018 •
edited
Loading

@ibrahimsharaf no, up to you, only one thing - width no more than 200-300, we no need large logos here.

@ibrahimsharaf ibrahimsharaf mentioned this issue Jan 27, 2018
Merged
sj29-innovate pushed a commit to sj29-innovate/gensim that referenced this issue Feb 21, 2018
@ibrahimsharaf @sj29-innovate
Store images from README.md directly in repository. Fix piskvorky#1849
85f84be 
 (piskvorky#1861)

* Add README images to repo

* Resize images

* Bigger images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty easy Easy issue: required small fix documentation Current issue related to documentation good first issue Issue for new contributors (not required gensim understanding + very simple)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibrahimsharaf @menshikh-iv