Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right column panels should not overflow out of the viewport #467

Closed
juliandescottes opened this issue May 7, 2016 · 1 comment
Closed

Right column panels should not overflow out of the viewport #467

juliandescottes opened this issue May 7, 2016 · 1 comment
Assignees
@juliandescottes
Labels
bug
Milestone
v0.8

Comments

@juliandescottes
Copy link
Collaborator

From https://twitter.com/dgrizzla/status/727932483724038144

The right column contains several panels :

  • minimap
  • layers list
  • transform tools
  • palette

The minimap and transform tools have fixed heights, the palette has a max-height defined, but the layers list can grow indefinitely if the user keeps adding layers :

image

Either:

  • define max-height on layers-list so that all panels never take more than container's height
  • use flexbox to adapt the height of the dynamic panels (palettes & layers) smoothly
@juliandescottes juliandescottes self-assigned this May 7, 2016
juliandescottes added a commit that referenced this issue May 8, 2016
@juliandescottes
Issue #467: fix max height for layers & panels lists
c1d8c7a
juliandescottes added a commit that referenced this issue May 8, 2016
@juliandescottes
Issue #467: style changes: smaller toolbox borders, layout fixes
7c47aa9
juliandescottes added a commit that referenced this issue May 8, 2016
@juliandescottes
Merge pull request #468 from juliandescottes/fix-layersoverflow
7e88aeb 
Issue #467: fix max height for layers & panels lists
@juliandescottes
Copy link
Collaborator Author

Fixed. To be released with 0.8.0

@juliandescottes juliandescottes added this to the v0.8 milestone Jul 3, 2016
@juliandescottes juliandescottes mentioned this issue Jul 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliandescottes juliandescottes

Labels
bug
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@juliandescottes