Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable keyboard shortcuts #287

Closed
AlexHolly opened this issue Jul 20, 2015 · 5 comments
Closed

Customizable keyboard shortcuts #287

AlexHolly opened this issue Jul 20, 2015 · 5 comments
Assignees
@juliandescottes
Labels
feature
Milestone
v0.6

Comments

@AlexHolly
Copy link
Contributor

Is there any way to set custom shortcuts?
It woul'd be nice to have such a feature.
@juliandescottes juliandescottes self-assigned this Oct 9, 2015
juliandescottes added a commit that referenced this issue Oct 9, 2015
@juliandescottes
Issue #287 : Rename addShortcut/removeShortcut to less ambiguous regi…
3367bd6 
…ster/unregister
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : Move shortcut definition to tool instances
ba525da
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : Fix unit test mocks
51eeeb2
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : Shortcuts now rely on Shortcut instances. Shortcut key c…
a9c3a05 
…an be changed dynamically.
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : fix shortcut for cheatsheet
628dd65
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : Move CheatsheetService to CheatsheetController + Dialogs…
dffb43a 
…Controller
juliandescottes added a commit that referenced this issue Oct 10, 2015
@juliandescottes
Issue #287 : Edit shortcuts from the Cheatsheet dialog (WIP)
cf5e1f1
juliandescottes added a commit that referenced this issue Oct 11, 2015
@juliandescottes
Issue #287 : Edit shortcuts from cheatsheet window (WIP)
09f33e8
juliandescottes added a commit that referenced this issue Oct 24, 2015
@juliandescottes
Issue #287 : Add forbidden keys & helptext
3e20e2e
juliandescottes added a commit that referenced this issue Oct 24, 2015
@juliandescottes
Issue #287 : Update helptext
03f5631
@juliandescottes
Copy link
Collaborator

Almost done with the implementation for this feature.

The shortcuts can be modified via the 'cheatsheet' dialog (opened when clicking on the keyboard icon).

I had to take a small shortcut to avoid making this too big. 4 shortcuts cannot be remapped :

  • 1 to 9 for selecting colors
  • ctrl + Y for redo
  • ? for opening the cheatsheet dialog
  • del to clear the current selection

And consequently the keys mapped to those shortcuts cannot be assigned to another shortcut. Other than this, everything is now customisable.

@juliandescottes juliandescottes added this to the v0.6 milestone Oct 24, 2015
@juliandescottes juliandescottes changed the title Set own shortcuts Customizable keyboard shortcuts Oct 28, 2015
@juliandescottes
Copy link
Collaborator

ezgif com-optimize

@AlexHolly
Copy link
Contributor Author

It's looking good where can I test it?

@juliandescottes
Copy link
Collaborator

For now it's only in development, so you would need to build the application to test it.

It will be released in v0.6.0 (no release date planned yet :) )

juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Rename addShortcut/removeShortcut to less ambiguous regi…
c11e0d5 
…ster/unregister
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Move shortcut definition to tool instances
2c75dae
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Fix unit test mocks
8081d5e
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Shortcuts now rely on Shortcut instances. Shortcut key c…
ca3bbf1 
…an be changed dynamically.
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : fix shortcut for cheatsheet
5cda3e5
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Move CheatsheetService to CheatsheetController + Dialogs…
b523408 
…Controller
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Edit shortcuts from the Cheatsheet dialog (WIP)
2e3558e
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Edit shortcuts from cheatsheet window (WIP)
676cbd1
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Add forbidden keys & helptext
0b439e1
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Update helptext
947306a
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Move helptext to tooltip, change cheatsheet column layout
460688e
juliandescottes added a commit that referenced this issue Nov 12, 2015
@juliandescottes
Issue #287 : Move utility functions from Shortcuts.js to ShortcutService
6d30941
@juliandescottes juliandescottes mentioned this issue Nov 12, 2015
Merged
@juliandescottes
Copy link
Collaborator

Will close after release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliandescottes juliandescottes

Labels
feature
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
2 participants
@juliandescottes @AlexHolly