Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests and CI, update types and use pool.run() instead of pool.runTask() #11

Merged
merged 10 commits into from
Jul 25, 2023

Conversation

darkgl0w
Copy link
Contributor

@darkgl0w darkgl0w commented Dec 5, 2021

Hello.

This PR aims to :

  • add GitHub action CI
  • swap the deprecated pool.runTask() with pool.run().
  • update typescript definitions (fix Updates to plugin.d.ts to support Fastify v3 #7) and add types tests.
  • update examples server code.
  • update package dependencies.
  • add tests to the package.

Note: typescript users may face issues when using fastify < 3.x, maybe we should also update the plugin.js fastify minimum required version field to >= 3.0.0.

Feel free to ping me if changes are required. ^^

@lucastasio
Copy link

Hi everyone and, above all, thanks in advance.
Since the request has been approved, is it possible to merge it with the current branch?
Thank you, again.

@metcoder95 metcoder95 merged commit e048210 into piscinajs:current Jul 25, 2023
@joshuagame
Copy link

Thank you so much @metcoder95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to plugin.d.ts to support Fastify v3
5 participants